refactor: separate client and server type generation to resolve build stru…#19
Open
imagekitio wants to merge 3 commits intomasterfrom
Open
refactor: separate client and server type generation to resolve build stru…#19imagekitio wants to merge 3 commits intomasterfrom
imagekitio wants to merge 3 commits intomasterfrom
Conversation
…cture issues - Create separate tsconfig.client.json and tsconfig.server.json - Update Rollup config to use specific TypeScript configurations for each build - Fix package.json exports to point to correct type definitions - Remove unused build:types script from package.json - Simplify include/exclude patterns in TypeScript configs This ensures server types (/server export) only contain server-side exports (getUploadAuthParams) instead of incorrectly including client components (Image, Video, ImageKitProvider). Closes: types build structure issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor: separate client and server type generation to resolve build structure issues